Skip to content

[PWGEM] Add Event Skimmer for Dalitz taking both V0 and Elec into acc… - #17787

Merged
jokonig merged 1 commit into
AliceO2Group:masterfrom
jokonig:master
Sep 7, 2026
Merged

[PWGEM] Add Event Skimmer for Dalitz taking both V0 and Elec into acc…#17787
jokonig merged 1 commit into
AliceO2Group:masterfrom
jokonig:master

Conversation

@jokonig

@jokonig jokonig commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

…ount

  • New skimmer needs tables from photon-conversion-builder and dalitz-electron-skimmer. Then, based no the contents of these tables, the final tables are written into the AO2D
  • Consequently, the photon-conversion-builder and the dalitz-skimmer need to be able to write temporary tables with the same content as the original tables
  • Added these temporary tables to the datamodel
  • Templated photon-conversion-builder and Dalitz-Skimmer to be able to write both types of tables
  • Added new Dalitz skimmer that reads these tables and then writes the non-temporary ones

@github-actions github-actions Bot added pwgem datamodel photon Photon and neutral meson PAG label labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 108 errors, ⚠️ 134 warnings, 🔕 27 disabled

@alibuild alibuild mentioned this pull request Sep 5, 2026
Closed
@jokonig
jokonig force-pushed the master branch 2 times, most recently from d6682d8 to 5e14c1a Compare September 6, 2026 15:23
@jokonig
jokonig marked this pull request as ready for review September 6, 2026 15:42
@jokonig
jokonig enabled auto-merge (squash) September 6, 2026 15:43
alibuild

This comment was marked as outdated.

Sign in to view

@alibuild

This comment was marked as outdated.

Sign in to view
@alibuild

This comment was marked as outdated.

Sign in to view
@alibuild alibuild mentioned this pull request Sep 6, 2026
Closed
dsekihat
dsekihat reviewed Sep 6, 2026
View reviewed changes
Comment thread PWGEM/Dilepton/DataModel/dileptonTables.h Outdated
@jokonig
jokonig disabled auto-merge September 6, 2026 19:56
@alibuild

This comment was marked as outdated.

Sign in to view
@jokonig
jokonig force-pushed the master branch 3 times, most recently from 5c8658a to e18376d Compare September 7, 2026 07:40
jokonig
[PWGEM] Add Event Skimmer for Dalitz taking both V0 and Elec into acc…
b6a8db4 
…ount

- New skimmer needs tables from photon-conversion-builder and dalitz-electron-skimmer. Then, based no the contents of these tables, the final tables are written into the AO2D
- Consequently, the photon-conversion-builder and the dalitz-skimmer need to be able to write temporary tables with the same content as the original tables
- Added these temporary tables to the datamodel
- Templated photon-conversion-builder and Dalitz-Skimmer to be able to write both types of tables
- Added new Dalitz skimmer that reads these tables and then writes the non-temporary ones
@jokonig
jokonig enabled auto-merge (squash) September 7, 2026 09:44
alibuild
alibuild approved these changes Sep 7, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jokonig.

@jokonig
jokonig merged commit b96b735 into AliceO2Group:master Sep 7, 2026
12 of 14 checks passed
@alibuild

alibuild commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b6a8db4 at 2026-09-07 17:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 41 errors and 0 warnings.'
Found 41 errors and 0 warnings.
++ [[ 41 -gt 0 ]]
++ cat /sw/BUILD/7181820aa0a00e92e1cb1d24b45e4be949ff168c/O2Physics-code-check/errors.txt
PWGEM/Dilepton/TableProducer/filterEoI.cxx:22:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/filterEoI.cxx:32:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilderTmpTable.cxx:19:16: error: no header providing "o2::framework::WorkflowSpec" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilderTmpTable.cxx:19:65: error: no header providing "o2::framework::ConfigContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilderTmpTable.cxx:22:5: error: no header providing "o2::framework::adaptAnalysisTask" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:19:16: error: no header providing "o2::framework::WorkflowSpec" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:19:65: error: no header providing "o2::framework::ConfigContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx:22:5: error: no header providing "o2::framework::adaptAnalysisTask" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:85:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:86:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:87:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:88:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:89:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:90:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:91:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:92:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:93:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.h:94:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:19:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:24:1: error: included header InitContext.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:33:54: error: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:33:67: error: no header providing "o2::aod::PMEvSels" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEETmpTable.cxx:22:1: error: no header providing "o2::framework::WorkflowSpec" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEETmpTable.cxx:22:35: error: no header providing "o2::framework::ConfigContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEETmpTable.cxx:24:17: error: no header providing "o2::pid::tof::TOFResponseImpl" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEETmpTable.cxx:27:5: error: no header providing "o2::framework::adaptAnalysisTask" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:22:1: error: no header providing "o2::framework::WorkflowSpec" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:22:35: error: no header providing "o2::framework::ConfigContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:24:17: error: no header providing "o2::pid::tof::TOFResponseImpl" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:27:5: error: no header providing "o2::framework::adaptAnalysisTask" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:39:1: error: included header AnalysisTask.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:70:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:71:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:72:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:73:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:74:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:75:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:76:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:77:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:78:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:79:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsekihat dsekihat dsekihat left review comments
@alibuild alibuild alibuild approved these changes
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@amaringarcia amaringarcia Awaiting requested review from amaringarcia amaringarcia is a code owner
@reygers reygers Awaiting requested review from reygers reygers is a code owner
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

Assignees

No one assigned

Labels

datamodel photon Photon and neutral meson PAG label pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jokonig @alibuild @dsekihat